Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps in ionic: gz-plugin3 #127

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Bumps in ionic: gz-plugin3 #127

merged 5 commits into from
Oct 16, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Oct 6, 2023

@azeey
Bumps in ionic : ci_matching_branch/bump_ionic_gz-plugin3
6697395 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@scpeters scpeters changed the title Bumps in ionic : ci_matching_branch/bump_ionic_gz-plugin3 Bumps in ionic: gz-plugin3 Oct 12, 2023
scpeters
scpeters reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to update the logic for setting GZ_TOOLS_VER at CMakeLists.txt:48

azeey added 3 commits October 13, 2023 15:47
@azeey
Merge remote-tracking branch 'origin/main' into ci_matching_branch/bu…
5a938f8 
…mp_ionic_gz-plugin3

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Remove focal
7b424d1 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Revert to gz-tools2
f54514c 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey marked this pull request as ready for review October 13, 2023 20:49
@azeey azeey requested review from mxgrey and ahcorde as code owners October 13, 2023 20:49
@azeey
Copy link
Contributor Author

azeey commented Oct 13, 2023

I think we need to update the logic for setting GZ_TOOLS_VER at CMakeLists.txt:48

Merged #119 that took care of this.

@azeey azeey requested a review from iche033 October 13, 2023 20:50
@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Merging #127 (d7a1766) into main (88d429b) will increase coverage by 0.46%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

❗ Current head d7a1766 differs from pull request most recent head 534d846. Consider uploading reports for the commit 534d846 to get more accurate results

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   98.26%   98.72%   +0.46%     
==========================================
  Files          23       23              
  Lines         748      785      +37     
==========================================
+ Hits          735      775      +40     
+ Misses         13       10       -3
Files Coverage Δ
loader/src/cmd/gz.cc 96.15% <ø> (+7.26%) ⬆️

... and 10 files with indirect coverage changes

iche033
iche033 reviewed Oct 13, 2023
View reviewed changes
test/integration/plugin.cc Outdated Show resolved Hide resolved
iche033
iche033 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment about unintended changes in test but they should be harmless

@azeey
Revert changes in plugin.cc
534d846 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey merged commit 6630fe3 into main Oct 16, 2023
6 checks passed
@azeey azeey deleted the ci_matching_branch/bump_ionic_gz-plugin3 branch October 16, 2023 21:34
@azeey azeey mentioned this pull request Oct 16, 2023
Closed
83 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters left review comments

@iche033 iche033 iche033 approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

@ahcorde ahcorde Awaiting requested review from ahcorde ahcorde is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azeey @scpeters @iche033